Delete the node dir when wiping all

[tillrohrmann]

WipeMode::All will now delete the whole node base dir to also
remove a cluster marker file.

This fixes #1629.

This PR is based on #1628.

[AhmedSoliman]

I wonder if we should go the opposite way and completely remove the wipe command. It might be better to ask users to remove (or rename) the data directory instead of providing this as a feature. What do you think?

[tillrohrmann]

I wonder if we should go the opposite way and completely remove the wipe command. It might be better to ask users to remove (or rename) the data directory instead of providing this as a feature. What do you think?

It is certainly a foot gun and trains people in bad habits. Maybe I only fix it then in the release-1.0 branch where we still have the wipe command and remove the wipe command in main?

[AhmedSoliman]

@tillrohrmann up to you.

[tillrohrmann]

I would merge the PR and open an issue to remove the wipe command or at least hide it for the next release (1.1).

[tillrohrmann]

The respective issue for removing/hiding the wipe command is #1650.