Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updateable nodes configuration #1666

Closed
wants to merge 3 commits into from
Closed

Updateable nodes configuration #1666

wants to merge 3 commits into from

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jun 27, 2024

Updateable nodes configuration

Nodes configuration is not optional anymore. Node configuration is empty with an INVALID version before loading.


Stack created with Sapling. Best reviewed with ReviewStack.

- Bifrost doesn't need to be mutable for normal appends
- Progress towards removing global access to metadata()
Address a chicken-and-an-egg problem at construction time of the runtime environment. MetadataBuilder helps by allowing the shared metadata object to be constructed early while encapsulating metadata's construction implementation details.
@AhmedSoliman AhmedSoliman changed the title updateable nodes configuration Updateable nodes configuration Jun 27, 2024
Copy link

Test Results

102 files  ±0  102 suites  ±0   20m 53s ⏱️ -4s
 84 tests ±0   84 ✅ ±0  0 💤 ±0  0 ❌ ±0 
215 runs  ±0  215 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 79b9dbf. ± Comparison against base commit 33073c7.

Copy link

Test Results

102 files  ±0  102 suites  ±0   20m 32s ⏱️ -25s
 84 tests ±0   84 ✅ ±0  0 💤 ±0  0 ❌ ±0 
215 runs  ±0  215 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 79b9dbf. ± Comparison against base commit 33073c7.

Nodes configuration is not optional anymore. Node configuration is empty with an INVALID version before loading.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant