Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Networking] Allow sending messages through Outgoing<M> #1928

Merged
merged 2 commits into from
Sep 9, 2024
Merged

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Sep 5, 2024

[Networking] Allow sending messages through Outgoing

Allows Outgoing values to be sent directly if they were reciprocal to Incoming.


Stack created with Sapling. Best reviewed with ReviewStack.

@AhmedSoliman AhmedSoliman changed the title [Networking] Outgoing [Networking] Allow sending messages through Outgoing<M> Sep 5, 2024
Copy link

github-actions bot commented Sep 5, 2024

Test Results

15 files  ±0  15 suites  ±0   19m 47s ⏱️ +16s
 6 tests ±0   6 ✅ ±0  0 💤 ±0  0 ❌ ±0 
18 runs  ±0  18 ✅ ±0  0 💤 ±0  0 ❌ ±0 

Results for commit 9c2d036. ± Comparison against base commit 81d73da.

♻️ This comment has been updated with latest results.

@AhmedSoliman AhmedSoliman marked this pull request as ready for review September 5, 2024 16:28
Copy link
Contributor

@pcholakov pcholakov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is really nice!

Allows Outgoing<M> values to be sent directly if they were reciprocal to Incoming.
@AhmedSoliman AhmedSoliman merged commit f632f65 into main Sep 9, 2024
4 checks passed
@AhmedSoliman AhmedSoliman deleted the pr1928 branch September 9, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants