[TestEnv] supporting routing responses back to callers #1947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: This is a small improvement over the existing TestCoreEnvBuilder networking by supporting routing responses back to RpcRouter when they make a call over the NetworkSender. This only works if the target component you are calling is registered against the same RouterBuilder as the client.
AhmedSoliman
approved these changes
Sep 11, 2024
|
@AhmedSoliman Thank you for reviewing my PR. And I definitely agree with you regarding being awkward to use. I tried to make this clear with comments as much as possible. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[TestEnv] supporting routing responses back to callers
Summary:
This is a small improvement over the existing TestCoreEnvBuilder networking
by supporting routing responses back to RpcRouter when they make a call over the
NetworkSender.
This only works if the target component you are calling is registered against the same
RouterBuilder as the client.