Add smoke tests for the Raft bassed metadata cluster #2582
Merged
+472
−136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
raft-smoke-test
branch
from
68a891f to
708239c
Compare
pcholakov
approved these changes
Jan 30, 2025
Comment on lines
79
to
84
| let failed_precondition = client | ||
| .put( | ||
| key.clone(), | ||
| &new_value, | ||
| Precondition::MatchesVersion(value_version.next()), | ||
| ) |
There was a problem hiding this comment.
This is perfect for a smoke test but if you wanted to, you could also add a Precondition::DoesNotExist attempt. Maybe it just makes the test extra verbose though, not sure.
There was a problem hiding this comment.
Good idea. Will add it as well.
|
|
||
| let start_chaos = Instant::now(); | ||
|
|
||
| let chaos_handle = TaskCenter::spawn_unmanaged(TaskKind::Background, "chaos", async move { |
There was a problem hiding this comment.
If only getting a handle on chaos was this easy in real life :-)
There was a problem hiding this comment.
That would make for an awesome business ;-)
tillrohrmann
force-pushed
the
raft-smoke-test
branch
2 times, most recently
from
b8a4fe0 to
9446ad4
Compare
Before, we stopped joining the cluster if were a member and had an ongoing join operation in flight. This was clearly wrong. This is no changed to only stop joining if one is no longer a member.
Metadata might lag a little bit behind what the KvMemoryStorage already knows. That's why the RaftMetadataStore now uses which ever NodesConfiguration is newer.
tillrohrmann
force-pushed
the
raft-smoke-test
branch
from
9446ad4 to
ee21142
Compare
tillrohrmann
force-pushed
the
raft-smoke-test
branch
from
ee21142 to
5e7d08f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #2572 and #2581.