Adjust metadata networking options #2589
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 30, 2025
Test Results 7 files ±0 7 suites ±0 4m 11s ⏱️ + 1m 17s For more details on these errors, see this check. Results for commit 3b08b24. ± Comparison against base commit d1a31ea. ♻️ This comment has been updated with latest results. |
tillrohrmann
approved these changes
Jan 30, 2025
Re-implemented the logic to propose new loglet configurations directly on any bifrost node. This unlocks the next PR which will use the auto_extend feature to auto-recover. ``` // intentionally empty ```
AhmedSoliman
force-pushed
the
pr2589
branch
2 times, most recently
from
a031a2a to
7f9ed44
Compare
In certain scenarios, if the appender is known to be running with "permission" to extend the chain, it'll run out of patience and will attempt to perform reconfiguration itself. This works really well, but it might compete with a cluster controller that thinks a different placement should take place. The auto-recovery mechanism only kicks in after 3 seconds (configurable) and we can see that the appender will attempt to reconfigure the loglet if it's sealed. At the moment, this will get the system out of trouble in certain scenarios. ``` // intentionally empty ```
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack created with Sapling. Best reviewed with ReviewStack.