Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Distribute restatectl #2606

Merged
merged 3 commits into from
Feb 3, 2025
Merged

Distribute restatectl #2606

merged 3 commits into from
Feb 3, 2025

Conversation

jackkleeman
Copy link
Contributor

@jackkleeman jackkleeman commented Feb 3, 2025 •
edited
Loading

  1. Add restatectl npm package
  2. Add restatectl brew formula
  3. Fix broken restate-cli dockerfile, and also include restatectl in this image (you would have to specify this entrypoint separately though)
  4. Distribute restatectl as part of release artifacts
  5. Notarize apple binaries

@jackkleeman jackkleeman changed the title Restatectl distribute Distribute restatectl Feb 3, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025 •
edited
Loading

Test Results

  7 files  ±0    7 suites  ±0   4m 28s ⏱️ +2s
 47 tests ±0   46 ✅ ±0  1 💤 ±0  0 ❌ ±0 
182 runs  ±0  179 ✅ ±0  3 💤 ±0  0 ❌ ±0 

Results for commit 8423d03. ± Comparison against base commit 86cd732.

♻️ This comment has been updated with latest results.

@jackkleeman jackkleeman force-pushed the restatectl-distribute branch from fb30675 to cf406e0 Compare February 3, 2025 10:30
@jackkleeman jackkleeman marked this pull request as ready for review February 3, 2025 10:57
@jackkleeman jackkleeman force-pushed the restatectl-distribute branch 3 times, most recently from 45fde9a to 63b0c11 Compare February 3, 2025 15:45
tillrohrmann
tillrohrmann approved these changes Feb 3, 2025
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for this PR @jackkleeman. The changes look good to me. +1 for merging.

.github/workflows/docker-release.yml Show resolved Hide resolved
.github/workflows/notarize.yml Show resolved Hide resolved
npm/restatectl/package.json Show resolved Hide resolved
@jackkleeman jackkleeman force-pushed the restatectl-distribute branch 2 times, most recently from 8423d03 to 1f646f3 Compare February 3, 2025 17:50
@jackkleeman jackkleeman merged commit e5e3c78 into main Feb 3, 2025
15 checks passed
@jackkleeman jackkleeman deleted the restatectl-distribute branch February 3, 2025 17:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jackkleeman @tillrohrmann