Minor improvements #2610
Merged
Minor improvements #2610
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
force-pushed
the
unhide-default-replication-property
branch
3 times, most recently
from
4aa0240 to
6c8c8d6
Compare
AhmedSoliman
approved these changes
Feb 4, 2025
| @@ -104,8 +104,7 @@ impl<T: TransportConnect> ClusterStateRefresher<T> { | |||
| cluster_state_tx: Arc<watch::Sender<Arc<ClusterState>>>, | |||
| ) -> Result<Option<TaskHandle<anyhow::Result<()>>>, ShutdownError> { | |||
| let refresh = async move { | |||
| // todo: potentially downgrade to trace()... | |||
| debug!("Refreshing cluster state"); | |||
| trace!("Refreshing cluster state"); | |||
There was a problem hiding this comment.
I think I fixed this in my PRs as well
This commit makes a few Rustdocs a bit more explanatory for users.
tillrohrmann
force-pushed
the
unhide-default-replication-property
branch
from
6c8c8d6 to
adfc493
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minor improvements