Make restatectl cluster provision and cluster config set more flexible #2620
Conversation
|
fyi @pcholakov regarding the restatectl work. |
There was a problem hiding this comment.
Thank you so much @tillrohrmann for PR. Looks great +1 for merging. I left few really minor comments.
I am wondering if BifrostProvider in cluster.proto should be dropped since you don't use it in provision call anymore and can be replaced with it's inner components also for ClusterConfiguration. But this can definitely be done in a separate PR.
|
I'll check how easy it is to drop the |
|
Removing the |
This commit makes the cluster provision and cluster config set command more flexible. It now allows to specify only a partial set of values and it will take the remaining values from the current cluster configuration/default values. Additionally, this commit introduces the new type NodeSetSize to enforce the upper limit of 128 across the configuration and API calls. This fixes restatedev#2604 and restatedev#2561.
tillrohrmann
force-pushed
the
issues/2604
branch
from
024bf2b to
1e9888f
Compare
No worries of course. I can do it tomorrow as a follow up :) |
This commit makes the cluster provision and cluster config set command more flexible. It now allows to specify only a partial set of values and it will take the remaining values from the current cluster configuration/default values.
Additionally, this commit introduces the new type NodeSetSize to enforce the upper limit of 128 across the configuration and API calls.
This fixes #2604 and #2561.