Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes restatectl setting target nodeset size #2645

Merged
merged 1 commit into from
Feb 6, 2025
Merged

Fixes restatectl setting target nodeset size #2645

merged 1 commit into from
Feb 6, 2025

Conversation

@AhmedSoliman AhmedSoliman force-pushed the pr2645 branch 2 times, most recently from 5ecfd4b to f82b2d2 Compare February 6, 2025 10:17
@AhmedSoliman AhmedSoliman marked this pull request as ready for review February 6, 2025 10:22
Copy link

github-actions bot commented Feb 6, 2025

Test Results

  7 files  ±0    7 suites  ±0   4m 30s ⏱️ +55s
 47 tests +2   46 ✅ +2  1 💤 ±0  0 ❌ ±0 
182 runs  +8  179 ✅ +8  3 💤 ±0  0 ❌ ±0 

Results for commit 00fdd95. ± Comparison against base commit d730f92.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@muhamadazmy muhamadazmy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! +1 for merging

Previously, setting target nodeset size with restatectl would tell you that "No change"
```
// intentionally empty
```
@AhmedSoliman AhmedSoliman merged commit b889da7 into main Feb 6, 2025
5 checks passed
@AhmedSoliman AhmedSoliman deleted the pr2645 branch February 6, 2025 19:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants