Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trim gap encountered errors include LSN #2744

Merged
merged 2 commits into from
Feb 17, 2025
Merged

Trim gap encountered errors include LSN #2744

merged 2 commits into from
Feb 17, 2025

Conversation

pcholakov
Copy link
Contributor

#folow-up

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 14, 2025 •
edited
Loading

Test Results

  7 files  ±0    7 suites  ±0   4m 23s ⏱️ +55s
 47 tests +2   46 ✅ +2  1 💤 ±0  0 ❌ ±0 
182 runs  +8  179 ✅ +8  3 💤 ±0  0 ❌ ±0 

Results for commit 9bbc718. ± Comparison against base commit 36ba21a.

♻️ This comment has been updated with latest results.

AhmedSoliman
AhmedSoliman approved these changes Feb 17, 2025
View reviewed changes
Copy link
Contributor

@AhmedSoliman AhmedSoliman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

An optional nit on naming, but in general good to go.

crates/worker/src/partition/mod.rs Outdated
Comment on lines 289 to 290
trim_gap_to_lsn = ?gap_to_lsn,
?sequence_number,
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we replace sequencer_number with read_pointer? or if it's easier to understand "trim_gap_start", "trim_gap_end"?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like it, tyvm!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I opted for "read_pointer" + "trim_gap_end" as it's most explicit about what's going on, I feel.

@pcholakov pcholakov merged commit a828991 into main Feb 17, 2025
27 checks passed
@pcholakov pcholakov deleted the trim-gap-sn-logging branch February 17, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AhmedSoliman AhmedSoliman AhmedSoliman approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pcholakov @AhmedSoliman