Cache AWS credentials in the snapshot uploader #2771
Conversation
| let runtime_components = RuntimeComponentsBuilder::for_tests() | ||
| .with_time_source(Some(aws_smithy_async::time::SystemTimeSource::new())) | ||
| .with_sleep_impl(Some(aws_smithy_async::rt::sleep::TokioSleep::new())) | ||
| .build() | ||
| .context("Could not build AWS runtime components")?; |
There was a problem hiding this comment.
Oof! At what point should we just use the S3 SDK 😆 Thank you for figuring this out!
There was a problem hiding this comment.
i think it doesnt help us really, unless you implement the object store trait on it :/. i can see why they didnt want to import the sdk, but its hurting us in this case tbh
There was a problem hiding this comment.
Thank you so much for fixing this, @jackkleeman! Can confirm it works exactly as intended. Tested with the following configurations:
- explicit env creds
- AWS SSO profile w/ S3
- AWS SDK profile w/ minio
- explicit Restate config w/ minio
It's probably worthwhile adding integration tests for these scenarios - not 100% what's the best place for them atm.
I took the liberty of pushing a trivial Clippy fix that was blocking merging. 😊
Unfortunately there is still a Rust SDK integration error which seems related to the test-services image being incompatible with Rust 2024.
No description provided.