Run e2e tests in CI #481
Run e2e tests in CI #481
Conversation
|
What's the plan wrt #460? Will the docker build step be replaced by downloading the binary and creating a docker image from it? Maybe this could also be part of this PR to give it more context. cc @slinkydeveloper. |
|
Yes, that is basically the plan, except it happens inside the e2e repo's workflow, not here. Here I just need to upload the artifact. Once that is working, I can set up the workflow call into the e2e repo |
|
I think #460 wouldnt be needed, just the cross repo workflow call |
|
I've no strong opinion on how to implement the e2e testing process, but i would like to have something merged very soon as it gives us more confidence on the overall stability. @jackkleeman if you think you'll have something ready soon, then let's close #460, otherwise i suggest we merge #460 and revert it once we have the more proper reusable workflow solution. WDYT? |
|
@slinkydeveloper i hope to have it working today |
jackkleeman
changed the title
There was a problem hiding this comment.
Thanks for creating this PR @jackkleeman. LGTM. +1 for merging once the required PR in the e2e repo has been merged.
With 1 day retention; so it can be used in e2e jobs
libc versions currently match docker; let's keep it that way
As part of restatedev/e2e#110
Fixes #454