Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move service_protocol_wireshark_dissector in the workspace #490

Merged
merged 2 commits into from
Jun 8, 2023
Merged

Move service_protocol_wireshark_dissector in the workspace #490

merged 2 commits into from
Jun 8, 2023

Conversation

slinkydeveloper
Copy link
Contributor

Fix #470

tillrohrmann
tillrohrmann reviewed Jun 8, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging once the build passes. There seems to be a problem with lua.

@slinkydeveloper slinkydeveloper merged commit d9f4e28 into restatedev:main Jun 8, 2023
@slinkydeveloper slinkydeveloper deleted the issues/470 branch June 8, 2023 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Move wireshark dissector to tools and include it in the workspace
2 participants
@slinkydeveloper @tillrohrmann