Introduce FixedConsecutivePartition partition table #527
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slinkydeveloper
approved these changes
Jun 23, 2023
| @@ -89,6 +89,7 @@ where | |||
| } | |||
| } | |||
|
|
|||
| #[instrument(level = "trace", skip_all, fields(peer_id = %self.peer_id, partition_id = %self.partition_id))] | |||
There was a problem hiding this comment.
Perhaps we can remove the debug log stmt a couple of lines below?
There was a problem hiding this comment.
Will remove it.
| @@ -58,6 +58,15 @@ pub(crate) struct Transaction<TransactionType> { | |||
| inner: TransactionType, | |||
| } | |||
|
|
|||
| impl<TransactionType> Transaction<TransactionType> { | |||
| fn assert_partition_key(&self, service_id: &ServiceId) { | |||
|
Thanks for the review @slinkydeveloper. Merging this PR now. |
This commit changes the PartitionKey to be a u32. This reduces the required bytes for the partition key while still keeping enough values to scale arbitrarily. This fixes #279.
The FixedConsecutivePartition partition table replaces the FixedPartitionTable. The latter partition table used a simple round robing partition key to partition assignment whereas the FixedConsecutivePartition partition table properly maps partition keys to their respective consecutive partition. This fixes #524.
Since all routable messages carry the PartitionKey, we no longer need to compute the PartitionKey from the key but can directly use the stored PartitionKey. This removes some computational complexity from the routing layer.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #525.
The FixedConsecutivePartition partition table replaces the FixedPartitionTable.
The latter partition table used a simple round robing partition key to partition
assignment whereas the FixedConsecutivePartition partition table properly maps
partition keys to their respective consecutive partition.
This fixes #524.