Move ConversionError from restate_common to restate_storage_api
#532
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillrohrmann
approved these changes
Jun 27, 2023
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes look good to me. I only had two minor comments.
src/storage_proto/src/lib.rs
Outdated
Comment on lines
23
to
27
| impl From<ConversionError> for StorageError { | ||
| fn from(value: ConversionError) -> Self { | ||
| StorageError::Conversion(value.into()) | ||
| } | ||
| } |
There was a problem hiding this comment.
If it weren't for this conversion, then we could avoid the dependency on restate_storage_api.
There was a problem hiding this comment.
I don't think it makes sense to avoid that, on the contrary it makes sense that this package depends on storage_proto, because this package is part of the implementation of the storage interface. Also see #536
There was a problem hiding this comment.
Look at the last commit, i aligned what i did here with what's in #536
slinkydeveloper
force-pushed
the
refactor-common/2
branch
from
29f3981 to
ee76055
Compare
slinkydeveloper
force-pushed
the
refactor-common/2
branch
from
ee76055 to
a1b1f92
Compare
…on `restate_storage_api` only for the conversions.
slinkydeveloper
force-pushed
the
refactor-common/2
branch
from
a1b1f92 to
4c96d34
Compare
tillrohrmann
approved these changes
Jun 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #420