Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce META REST endpoint to get a service endpoint by id #565

Merged
merged 2 commits into from
Jul 10, 2023

Conversation

slinkydeveloper
Copy link
Contributor

Fix #564. Based on #563

Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

src/serde_util/src/header_map.rs Outdated Show resolved Hide resolved
/// Discover endpoint and return discovered endpoints.
#[openapi(
summary = "Discover service endpoint",
description = "Discover service endpoint and register it in the meta information storage. If the service endpoint is already registered, it will be re-discovered and will override the previous stored metadata.",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The description seems outdated since we are no longer overwriting metadata by default.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this in the next PR

src/schema_impl/src/endpoint.rs Outdated Show resolved Hide resolved
@slinkydeveloper slinkydeveloper merged commit a61c923 into restatedev:main Jul 10, 2023
@slinkydeveloper slinkydeveloper deleted the issues/501_part_2 branch July 10, 2023 10:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rest endpoint to get service endpoint
2 participants