Provide a knob to configure HTTP/2 keep-alive #632
Conversation
There was a problem hiding this comment.
Thanks for creating this PR @slinkydeveloper. The changes make sense. I had a question about how to unset the http2_keep_alive option. If this is resolved, then +1 for merging.
src/invoker/src/options.rs
Outdated
| /// # HTTP/2 Keep alive options | ||
| /// | ||
| /// Configuration for the HTTP/2 keep-alive mechanism, using PING frames. | ||
| /// If unset, HTTP/2 keep-alive are disabled. |
There was a problem hiding this comment.
How can the user unset this struct? Shouldn't this comment apply to the field in the Options struct? In the yaml would I specify http2_keep_alive: null? How would I unset this value via the env variables?
There was a problem hiding this comment.
In the yaml would I specify http2_keep_alive: null?
Yes
How would I unset this value via the env variables?
I guess it's this one #478 that we haven't solved yet.
There was a problem hiding this comment.
Shouldn't this comment apply to the field in the Options struct?
Added the description to the field as well.
Enable them by default. Fix #624