Fix response of attach/getOutput

restatedev · May 13, 2024 · 1411eff · 1411eff
1 parent cd7332d
commit 1411eff
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 3 deletions.
diff --git a/sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/ingress.kt b/sdk-api-kotlin/src/main/kotlin/dev/restate/sdk/kotlin/ingress.kt
@@ -13,9 +13,9 @@ import dev.restate.sdk.client.IngressClient
 import dev.restate.sdk.client.RequestOptions
 import dev.restate.sdk.common.Serde
 import dev.restate.sdk.common.Target
-import kotlinx.coroutines.future.await
 import kotlin.time.Duration
 import kotlin.time.toJavaDuration
+import kotlinx.coroutines.future.await
 
 // Extension methods for the IngressClient
 

diff --git a/sdk-common/src/main/java/dev/restate/sdk/client/DefaultIngressClient.java b/sdk-common/src/main/java/dev/restate/sdk/client/DefaultIngressClient.java
@@ -194,7 +194,15 @@ public <Res> CompletableFuture<Res> attachAsync(Serde<Res> resSerde, RequestOpti
                     handleNonSuccessResponse(response);
                   }
 
-                  return null;
+                  try {
+                    return resSerde.deserialize(response.body());
+                  } catch (Exception e) {
+                    throw new IngressException(
+                        "Cannot deserialize the response",
+                        response.statusCode(),
+                        response.body(),
+                        e);
+                  }
                 });
       }
 
@@ -224,7 +232,15 @@ public <Res> CompletableFuture<Res> getOutputAsync(
                     handleNonSuccessResponse(response);
                   }
 
-                  return null;
+                  try {
+                    return resSerde.deserialize(response.body());
+                  } catch (Exception e) {
+                    throw new IngressException(
+                        "Cannot deserialize the response",
+                        response.statusCode(),
+                        response.body(),
+                        e);
+                  }
                 });
       }
     };