Log service discovery requests.

restatedev · Oct 30, 2023 · 1977f52 · 1977f52
1 parent 67096de
commit 1977f52
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 4 deletions.
diff --git a/sdk-core-impl/src/main/java/dev/restate/sdk/core/impl/RestateGrpcServer.java b/sdk-core-impl/src/main/java/dev/restate/sdk/core/impl/RestateGrpcServer.java
@@ -136,7 +136,11 @@ public void start() {
 
   public Discovery.ServiceDiscoveryResponse handleDiscoveryRequest(
       Discovery.ServiceDiscoveryRequest request) {
-    return this.serviceDiscoveryHandler.handle(request);
+    Discovery.ServiceDiscoveryResponse response = this.serviceDiscoveryHandler.handle(request);
+    LOG.info(
+        "Replying to service discovery request with services [{}]",
+        String.join(",", response.getServicesList()));
+    return response;
   }
 
   // -- Builder

diff --git a/sdk-http-vertx/src/main/java/dev/restate/sdk/http/vertx/RequestHttpServerHandler.java b/sdk-http-vertx/src/main/java/dev/restate/sdk/http/vertx/RequestHttpServerHandler.java
@@ -35,7 +35,7 @@ class RequestHttpServerHandler implements Handler<HttpServerRequest> {
 
   private static final Pattern SLASH = Pattern.compile(Pattern.quote("/"));
 
-  private static final String SERVICES_PATH = "/discover";
+  private static final String DISCOVER_PATH = "/discover";
 
   static TextMapGetter<MultiMap> OTEL_TEXT_MAP_GETTER =
       new TextMapGetter<>() {
@@ -72,15 +72,17 @@ public void handle(HttpServerRequest request) {
     URI uri = URI.create(request.uri());
 
     // Let's first check if it's a discovery request
-    if (SERVICES_PATH.equalsIgnoreCase(uri.getPath())) {
+    if (DISCOVER_PATH.equalsIgnoreCase(uri.getPath())) {
       this.handleDiscoveryRequest(request);
       return;
     }
 
     // Parse request
     String[] pathSegments = SLASH.split(uri.getPath());
     if (pathSegments.length < 3) {
-      LOG.warn("Path doesn't match the pattern /invoke/SvcName/MethodName: '{}'", request.path());
+      LOG.warn(
+          "Path doesn't match the pattern /invoke/SvcName/MethodName nor /discover: '{}'",
+          request.path());
       request.response().setStatusCode(NOT_FOUND.code()).end();
       return;
     }