Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Race condition in blocking mode when polling the input #74

Closed
tillrohrmann opened this issue Mar 15, 2023 · 0 comments · Fixed by #75
Closed

Race condition in blocking mode when polling the input #74

tillrohrmann opened this issue Mar 15, 2023 · 0 comments · Fixed by #75
Assignees
@tillrohrmann
Milestone
1A

Comments

@tillrohrmann
Copy link
Contributor

We seem to have a race condition when polling the input in the RestateServerCall:

sdk-java/sdk-core-impl/src/main/java/dev/restate/sdk/core/impl/RestateServerCall.java

Lines 160 to 162 in cf812be

LOG.trace("Read input message:\n{}", message);
listener.onMessage(message);
listener.onHalfClose();

The problem seems to be that we are executing the onMessage and onHalfClose call as separate tasks in an executor where the latter can overtake the former.
@tillrohrmann tillrohrmann added this to the 1A milestone Mar 15, 2023
@tillrohrmann tillrohrmann self-assigned this Mar 15, 2023
@tillrohrmann tillrohrmann mentioned this issue Mar 15, 2023
Merged
slinkydeveloper added a commit that referenced this issue Mar 22, 2024
@slinkydeveloper
Squashed 'sdk-core/src/main/service-protocol/' changes from 4378d559.…
e9075b5 
….29b28f98

29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80)
26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79)
61ae44b2 Update documentation on error codes (#77)
576a1b26 Add HandlerType. Fix #1092 (#76)
0624d092 Payload schema for input and output. This provides basic format awareness. (#74)

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 29b28f9867734bc01dd47c4666d9d56c90b626f5
slinkydeveloper added a commit that referenced this issue Mar 22, 2024
@slinkydeveloper
Adapt latest protocol changes (#258)
0dadbd6 
* Squashed 'sdk-core/src/main/service-protocol/' changes from 4378d559..29b28f98

29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80)
26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79)
61ae44b2 Update documentation on error codes (#77)
576a1b26 Add HandlerType. Fix #1092 (#76)
0624d092 Payload schema for input and output. This provides basic format awareness. (#74)

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 29b28f9867734bc01dd47c4666d9d56c90b626f5

* Changes due to the protocol update
slinkydeveloper added a commit that referenced this issue Apr 16, 2024
@slinkydeveloper
Squashed 'sdk-core/src/main/service-protocol/' changes from 4378d559.…
4b172b6 
….98bd326c

98bd326c Entry names + specify the entry that caused the failure in ErrorMessage (#86)
c47e65b0 Describe x-restate-user-agent (#85)
d43de04c Describe side effects in protocol (#84)
29b28f98 Modify Input/Output schema in deployment_manifest_schema.json (#80)
26d91e69 Replace protocol Empty message with custom one, so we remove the dependency on protobuf built-in messages (#79)
61ae44b2 Update documentation on error codes (#77)
576a1b26 Add HandlerType. Fix #1092 (#76)
0624d092 Payload schema for input and output. This provides basic format awareness. (#74)

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 98bd326c23f060d962821bca982bbb881e32c540
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tillrohrmann tillrohrmann

Labels
None yet
Projects
None yet
Milestone
1A
Development

Successfully merging a pull request may close this issue.

Combine onMessage and onHalfClose callbacks into single call to avoid race condition
1 participant
@tillrohrmann