-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Awakeable IDs following the new ID scheme #204
Conversation
Test Results102 files ±0 102 suites ±0 14m 34s ⏱️ + 4m 2s For more details on these failures, see this check. Results for commit ffa3282. ± Comparison against base commit e6c3980. ♻️ This comment has been updated with latest results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a small nit. Once it's green, you can merge.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we bump the protocol version to mark this change as a non-backwards compatible change?
For posterity, tests pass locally but we have a full mesh of dependency such that there is no way e2e tests will pass without merging the sdk first. |
Awakeable IDs following the new ID scheme