Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Awakeable IDs following the new ID scheme #204

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Awakeable IDs following the new ID scheme #204

merged 1 commit into from
Jan 26, 2024

Conversation

AhmedSoliman
Copy link
Contributor

@AhmedSoliman AhmedSoliman commented Jan 25, 2024

Awakeable IDs following the new ID scheme

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Test Results

102 files  ±0  102 suites  ±0   14m 34s ⏱️ + 4m 2s
 93 tests ±0   86 ✅  -  7  0 💤 ±0   7 ❌ + 7 
232 runs  ±0  217 ✅  - 15  0 💤 ±0  15 ❌ +15 

For more details on these failures, see this check.

Results for commit ffa3282. ± Comparison against base commit e6c3980.

♻️ This comment has been updated with latest results.

Copy link
Contributor

github-actions bot commented Jan 25, 2024

Unit Test Results

597 tests  ±0   583 ✔️  - 7   4m 52s ⏱️ + 1m 8s
  46 suites ±0       7 💤 ±0 
  46 files   ±0       7 +7 

For more details on these failures, see this check.

Results for commit ffa3282. ± Comparison against base commit e6c3980.

♻️ This comment has been updated with latest results.

Copy link
Contributor

@slinkydeveloper slinkydeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a small nit. Once it's green, you can merge.

sdk-core/src/main/java/dev/restate/sdk/core/Entries.java Outdated Show resolved Hide resolved
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we bump the protocol version to mark this change as a non-backwards compatible change?

@AhmedSoliman AhmedSoliman changed the title [WIP] Awakeable IDs following the new ID scheme Awakeable IDs following the new ID scheme Jan 26, 2024
@AhmedSoliman AhmedSoliman merged commit f27c278 into main Jan 26, 2024
4 of 8 checks passed
@AhmedSoliman
Copy link
Contributor Author

For posterity, tests pass locally but we have a full mesh of dependency such that there is no way e2e tests will pass without merging the sdk first.

@AhmedSoliman AhmedSoliman deleted the pr204 branch January 26, 2024 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants