Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Propagate the ProtocolMode in service discovery #71

Merged
merged 3 commits into from
Mar 16, 2023
Merged

Propagate the ProtocolMode in service discovery #71

merged 3 commits into from
Mar 16, 2023

Conversation

slinkydeveloper
Copy link
Contributor

@slinkydeveloper
Squashed 'sdk-core-impl/src/main/service-protocol/' changes from 3be5…
9f45392 
…df6..6616d84

6616d84 Add protocol mode to discovery (#16)

git-subtree-dir: sdk-core-impl/src/main/service-protocol
git-subtree-split: 6616d840f68031c62adf1125356e4156b898d8ea
@slinkydeveloper
Merge commit '9f45392cdd157ea6a23c939df5a025ade52d95b7' into protocol…
14c75c2 
…-type
@slinkydeveloper
Propagate the protocol mode
710be71
@github-actions
Copy link
Contributor

Unit Test Results

100 tests  ±0   100 ✔️ ±0   5s ⏱️ ±0s
  13 suites ±0       0 💤 ±0 
  13 files   ±0       0 ❌ ±0 

Results for commit 710be71. ± Comparison against base commit cf812be.

tillrohrmann
tillrohrmann approved these changes Mar 15, 2023
View reviewed changes
Copy link
Contributor

@tillrohrmann tillrohrmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. +1 for merging.

@slinkydeveloper slinkydeveloper merged commit ac7be07 into main Mar 16, 2023
@slinkydeveloper slinkydeveloper deleted the protocol-type branch March 16, 2023 08:55
slinkydeveloper added a commit that referenced this pull request Mar 18, 2024
@slinkydeveloper
Squashed 'sdk-core/src/main/service-protocol/' changes from fd7eb24..…
e29dcc2 
…4378d55

4378d55 Move headers into InputStreamEntry. (#75)
433d446 Remove the old discovery. Fix #71

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 4378d559db7a53a477dd091b636a64712b2b630e
slinkydeveloper added a commit that referenced this pull request Mar 18, 2024
@slinkydeveloper
Squashed 'sdk-core/src/main/service-protocol/' changes from fd7eb24..…
762821a 
…4378d55

4378d55 Move headers into InputStreamEntry. (#75)
433d446 Remove the old discovery. Fix #71

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 4378d559db7a53a477dd091b636a64712b2b630e
slinkydeveloper added a commit that referenced this pull request Mar 20, 2024
@slinkydeveloper
Squashed 'sdk-core/src/main/service-protocol/' changes from fd7eb24..…
1ff9a17 
…4378d55

4378d55 Move headers into InputStreamEntry. (#75)
433d446 Remove the old discovery. Fix #71

git-subtree-dir: sdk-core/src/main/service-protocol
git-subtree-split: 4378d559db7a53a477dd091b636a64712b2b630e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillrohrmann tillrohrmann tillrohrmann approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@slinkydeveloper @tillrohrmann