Fix content length of file parameter #769
Conversation
dgreenbean
force-pushed
the
feature/add_file_action_content_length
branch
from
696f018 to
85892db
Compare
|
This is to address issue #742. |
| @@ -158,9 +158,10 @@ public interface IRestRequest | |||
| /// <param name="name">The parameter name to use in the request</param> | |||
| /// <param name="writer">A function that writes directly to the stream. Should NOT close the stream.</param> | |||
| /// <param name="fileName">The file name to use for the uploaded file</param> | |||
| /// <param name="contentLength">The length (in bytes) of the file content.</param> | |||
There was a problem hiding this comment.
Please fix the spacing difference here.
|
Code looks good. Just some minor things that need to be changed first. Also, any idea on why this broke? I haven't looked into it too deeply yet but I'm concerned about changing the method signature and breaking other implementations. |
dgreenbean
force-pushed
the
feature/add_file_action_content_length
branch
from
85892db to
16f48c0
Compare
|
I didn't look too closely at why this broke. Since the method is currently broken anyway, I wasn't too concerned about changing the signature. If you think the compiler errors could cause problems for people, I could make this method throw an Exception and add a new method that works. That felt like overkill to me. |
|
The spacing should be fixed now. I'm guessing at the moment that the AppVeyor failure is unrelated to the change. Please let me know if this is not the case. |
|
it is unrelated unless it doesn't run successfully locally :) |
|
@hallem Is there anything blocking this from being merged? |
|
no i just haven't had time to sit down and work on this. i've recently moved so i'm still dealing with all that. i should have some time soon. |
…nt_length Fix content length of file parameter
Adding required input of content length when adding a file using a writer action.