Replace immutable and mutable HashSet and HashMap with the legacy Scala 2.12 implementations #125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retronym
force-pushed
the
legacy-hash-map-set
branch
from
b501cfe to
3397160
Compare
retronym
changed the title
- Special case result sizes of 0-4 and avoid mutable.HashMap allocation. - Fuse some lambdas into `object grouper`. Forward port cdfcf96
In the example, `apply` is overloaded. Overloading resolution uses `setSymbol` and `setType` once it has selected a winner. https://github.com/scala/scala/blob/v2.13.14/src/compiler/scala/tools/nsc/typechecker/Infer.scala#L1530 In the case of a `TypeApply` tree: - `setSymbol` delegates to the nested `Apply` tree - `setType` sets the type of the `TypeApply` This means that the nested `Apply` tree keeps its OverloadedType. This tripped up `fun.tpe.finalResultType.typeSymbol` in RefChecks (NoSymbol). It's not obvious how to assign the right type to the `Apply` tree, so I left it alone.
Emit the label def in a preceding statement to the user code, rather than wrapping it. We can remove the workaround with `def canJump = !isAsync`, which wasn't working for custom async implementations that followed the patmat phase.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creating a stepping stone for a large 2.12 to 2.13 migration.