Handle empty files and unknown line endings better #34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Return an empty result if the file is empty to skip the file * Only throw an exception when line ending is unknown, if the line ending configuration is set to KEEP * When reading all lines from the buffer into a list, do not depend on the previously detected line endings, and instead read all lines as-is, regardless of line ending previously detected
ctubbsii
force-pushed
the
skip-empty-files
branch
from
1d99d17 to
7f652fe
Compare
dwalluck
reviewed
Sep 10, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ending configuration is set to KEEP
the previously detected line endings, and instead read all lines
as-is, regardless of line ending previously detected