Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue where first comment above import is duplicated #36

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

bruce-y
Copy link
Contributor

@bruce-y bruce-y commented Oct 1, 2020

No description provided.

@bruce-y bruce-y force-pushed the by-ng/fix-first-import-comment branch 2 times, most recently from 729676e to e779fac Compare October 1, 2020 16:34
Copy link
Member

@ctubbsii ctubbsii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, @bruce-au

@ctubbsii ctubbsii added this to the 1.5.0 milestone Oct 1, 2020
@bruce-y bruce-y force-pushed the by-ng/fix-first-import-comment branch from e779fac to 3a0c3e8 Compare October 5, 2020 15:28
@bruce-y
Copy link
Contributor Author

bruce-y commented Oct 5, 2020

Addressed comments

@bruce-y bruce-y requested a review from ctubbsii October 5, 2020 15:30
@bruce-y bruce-y force-pushed the by-ng/fix-first-import-comment branch from 3a0c3e8 to de26fd8 Compare October 5, 2020 15:34
@ctubbsii
Copy link
Member

ctubbsii commented Oct 5, 2020

Thanks, @bruce-au ; I will test on a large project before merging, but it looks good to me. Thanks!

@ctubbsii
Copy link
Member

ctubbsii commented Oct 6, 2020

Tested on a large project, and didn't notice any problems. Thanks!

@ctubbsii ctubbsii merged commit 91fc770 into revelc:main Oct 6, 2020
@bruce-y bruce-y deleted the by-ng/fix-first-import-comment branch October 6, 2020 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impsort duplicates comments above first import if there is no space separation
2 participants