Fix flickering of remote-only menu

reverbdotcom · May 8, 2015 · 79b4f08 · 79b4f08
1 parent 588440f
commit 79b4f08
Showing 1 changed file with 10 additions and 3 deletions.
diff --git a/src/typeahead/dataset.js b/src/typeahead/dataset.js
@@ -255,7 +255,9 @@ var Dataset = (function() {
         suggestions = (suggestions || []).slice(0, that.limit);
         rendered = suggestions.length;
 
-        that._overwrite(query, suggestions);
+        if (suggestions.length) {
+          that._overwrite(query, suggestions);
+        }
 
         if (rendered < that.limit && that.async) {
           that.trigger('asyncRequested', query);
@@ -269,9 +271,14 @@ var Dataset = (function() {
         // do not render the suggestions as they've become outdated
         if (!canceled && rendered < that.limit) {
           that.cancel = $.noop;
-          rendered += suggestions.length;
-          that._append(query, suggestions.slice(0, that.limit - rendered));
 
+          if (rendered === 0) {
+            that._overwrite(query, suggestions.slice(0, that.limit - rendered));
+          } else {
+            that._append(query, suggestions.slice(0, that.limit - rendered));
+          }
+
+          rendered += suggestions.length;
           that.async && that.trigger('asyncReceived', query);
         }
       }