Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: restart polling on NFC tag connection error [iOS 16] #638

Merged

Conversation

storm2513
Copy link
Contributor

Issue description:

After updating to iOS 16 in 50% cases we get error in requestTechnology call due to error in connecting to tag.
It is easily reproducible if we move iPhone during NFC scanning.

What changes have been made?

  • changed logic to restart polling instead of raising error during sensor connection

Result

After applying this patch it works reliably and scans without any issues on iOS 16.
Logs:

NFCTag didDetectTags
[CoreNFC] -[NFCTagReaderSession _connectTag:error:]:730 Error Domain=NFCError Code=100 "Tag connection lost" UserInfo={NSLocalizedDescription=Tag connection lost}
NFCTag restarting polling
NFCTag didDetectTags
[CoreNFC] -[NFCTagReaderSession _connectTag:error:]:730 Error Domain=NFCError Code=100 "Tag connection lost" UserInfo={NSLocalizedDescription=Tag connection lost}
NFCTag restarting polling
FCTag didDetectTags
// success

After connection error it immediately finds the same tag and connects again.

@storm2513 storm2513 changed the title Bug: restart polling on NFC tag connection error Bug: restart polling on NFC tag connection error [iOS 16] May 30, 2023
@whitedogg13 whitedogg13 merged commit 5e7b932 into revtel:main May 31, 2023
@whitedogg13
Copy link
Member

@storm2513 it's awesome, thanks!

@whitedogg13
Copy link
Member

@storm2513 this one has been included in latest v3.14.5 release, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants