Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(recognition)!: refactor whole recognition service #236

Merged
merged 14 commits into from
Jul 30, 2024

Conversation

Mala1180
Copy link
Collaborator

No description provided.

@Mala1180 Mala1180 added breaking change Public API modified, it will trigger a MAJOR release dependencies Updated dependencies refactor Refactored some feature autorebase-update Triggers the CI environment to automatically update the PR by rebasing, wherever it get oudated labels Jul 29, 2024
Copy link

mergify bot commented Jul 29, 2024

Merge Protections

Your pull request matches the following merge protections and will not be merged until they are valid.

Developer PR

Rule to follow in order to successfully merge to main

  • #approved-reviews-by>=1
  • title ~= ^(fix|feat|docs|style|refactor|perf|test|build|ci|chore|revert)(?:(.+))?:

@kelvin-olaiya kelvin-olaiya force-pushed the feature/recognition-update branch 2 times, most recently from 9937350 to b69b223 Compare July 29, 2024 15:28
kelvin-olaiya
kelvin-olaiya previously approved these changes Jul 29, 2024
@kelvin-olaiya kelvin-olaiya enabled auto-merge (squash) July 29, 2024 15:50
paga16-hash
paga16-hash previously approved these changes Jul 29, 2024
Copy link
Collaborator

@paga16-hash paga16-hash left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work with tests!
The only thing that I noticed is the "camera" instead of "thing" but no problem. :D

@Mala1180 Mala1180 dismissed stale reviews from paga16-hash and kelvin-olaiya via a53e2bc July 29, 2024 19:31
@kelvin-olaiya kelvin-olaiya force-pushed the feature/recognition-update branch 6 times, most recently from 3aa427a to b79686c Compare July 30, 2024 03:53
@kelvin-olaiya kelvin-olaiya force-pushed the feature/recognition-update branch from b79686c to bc3751d Compare July 30, 2024 07:58
Copy link

@Mala1180 Mala1180 requested a review from kelvin-olaiya July 30, 2024 08:09
@Mala1180 Mala1180 requested review from paga16-hash and removed request for paga16-hash July 30, 2024 08:11
@kelvin-olaiya kelvin-olaiya merged commit 710934d into main Jul 30, 2024
15 checks passed
@Mala1180 Mala1180 deleted the feature/recognition-update branch July 30, 2024 08:12
revue-ci pushed a commit that referenced this pull request Jul 30, 2024
## [3.0.0](v2.3.2...v3.0.0) (2024-07-30)

### ⚠ BREAKING CHANGES

* **recognition:** refactor whole recognition service (#236)

### Dependency updates

* **deps:** update dependency @rushstack/eslint-patch to v1.10.4 ([9ccdc9e](9ccdc9e))
* **deps:** update dependency rollup to v4.19.1 ([dfb8ab3](dfb8ab3))

### Refactoring

* **recognition:** refactor whole recognition service ([#236](#236)) ([710934d](710934d))

## [3.0.0](v2.3.2...v3.0.0) (2024-07-30)

### ⚠ BREAKING CHANGES

* **recognition:** refactor whole recognition service (#236)

### Code Refactoring

* **recognition:** refactor whole recognition service ([#236](#236)) ([710934d](710934d))
@revue-ci
Copy link
Collaborator

🎉 This issue has been resolved in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
autorebase-update Triggers the CI environment to automatically update the PR by rebasing, wherever it get oudated breaking change Public API modified, it will trigger a MAJOR release dependencies Updated dependencies refactor Refactored some feature released
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants