Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Change the Hierarchy to support egui::CollapsingHeader #121

Merged
merged 8 commits into from
Dec 17, 2023

Conversation

MickHarrigan
Copy link
Contributor

This is a quick change that converts the selectable_labels being used for the hierarchy to CollapsingHeaders.

There is still an issue with some entities that are brought in from .glb files it seems and I would love some feedback about that.

Otherwise I believe that this is just a small feature update.

@MickHarrigan
Copy link
Contributor Author

Added a check for each entity to see if the children that it has implement the PrefabMarker that is required to be shown correctly in the editor.
This should (hopefully) fix the issue with the .glb files referenced earlier.

@rewin123
Copy link
Owner

Thanks for the pull request!
It's a nice addition. I'll check it today

@rewin123
Copy link
Owner

Looks almost like a working solution already. I only found a bug that when adding a child to an entity, the parent entity is moved one space along with the child. Only the child should be moved one space.

After that, the pull request will be ready for merging.

@rewin123 rewin123 added the enhancement New feature or request label Dec 17, 2023
@rewin123 rewin123 added this to the 0.3 milestone Dec 17, 2023
@rewin123
Copy link
Owner

rewin123 commented Dec 17, 2023

I hope you don't mind, I fixed the described problem and got rid of code duplication. If you like my solution, pull request is ready to be merged with the main branch and will be in 0.3 version.

@MickHarrigan
Copy link
Contributor Author

No worries on the edits and all, that was what I was looking for! Otherwise it looks all good to me.

@MickHarrigan MickHarrigan marked this pull request as ready for review December 17, 2023 16:35
@rewin123 rewin123 merged commit 976f3c6 into rewin123:main Dec 17, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants