Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BRUTEFORCE] Fixes editor crash when using it as plugin #200

Closed
wants to merge 1 commit into from

Conversation

naomijub
Copy link
Collaborator

Addresses issue #191

Creates necessary filesystem when using space_editor as plugin

obs: My initial idea was to store the content as svg and render the svgs with bevy, but bevy and third parties plugins dont support svg as image, so I kept the initial approach and created a file system based on that

@naomijub naomijub requested a review from rewin123 February 18, 2024 23:07
@naomijub
Copy link
Collaborator Author

This is a less brute force solution for the problem. However, I seem to be messing the the scheduling of the components #201

@naomijub naomijub changed the title Fixes editor crash when using it as plugin [BRUTEFORCE] Fixes editor crash when using it as plugin Feb 20, 2024
@rewin123
Copy link
Owner

I tested on empty project. Had compilation error

image

@rewin123
Copy link
Owner

Looks that error reaises from moving from bevy_egui to bevy_egui_next. I think we need add to CI pipeline chack that space_editor compilates and runs as plugin

@naomijub
Copy link
Collaborator Author

naomijub commented Feb 21, 2024

This error is because of the patch, we need to add patch to cargo toml. It is actually in the docs:

# For now it is recomendended to use the following patches of the libraries we are using
[patch.crates-io]
egui-gizmo = { git = "https://github.com/naomijub/egui-gizmo.git" }
bevy-inspector-egui ={ git = "https://github.com/naomijub/bevy-inspector-egui.git" }

we could just retarget them to the repos and once we move to bevy 0.13 remove them

@rewin123
Copy link
Owner

Editr was compiled after update rust version and add patch in Cargo. But I got infinity loading

image

@naomijub naomijub closed this Feb 22, 2024
@naomijub naomijub deleted the issue-191/editor-crash branch March 5, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants