Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiple selection #214

Merged
merged 5 commits into from
Feb 25, 2024
Merged

Fix multiple selection #214

merged 5 commits into from
Feb 25, 2024

Conversation

rewin123
Copy link
Owner

@rewin123 rewin123 requested a review from naomijub February 24, 2024 20:47
@naomijub
Copy link
Collaborator

Will take a look after lunch

@rewin123
Copy link
Owner Author

Will take a look after lunch

Thanks!

@codecov-commenter
Copy link

codecov-commenter commented Feb 24, 2024

Codecov Report

Attention: Patch coverage is 0% with 49 lines in your changes are missing coverage. Please review.

❗ No coverage uploaded for pull request base (main@b9335ae). Click here to learn what that means.

Files Patch % Lines
crates/editor_ui/src/tools/gizmo.rs 0.00% 49 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main     #214   +/-   ##
=======================================
  Coverage        ?   12.69%           
=======================================
  Files           ?       54           
  Lines           ?     7112           
  Branches        ?        0           
=======================================
  Hits            ?      903           
  Misses          ?     6209           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@naomijub naomijub left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to be working, but there is a visual issue that annoys me, when you select holding shift, I can only see the main gizmos, I would include a wireframe on multi selected elements

@rewin123
Copy link
Owner Author

several lines running from the central gizmo to the centres of all selected objects?

@rewin123
Copy link
Owner Author

image

@rewin123 rewin123 requested a review from naomijub February 25, 2024 10:23
@rewin123 rewin123 added the bug Something isn't working label Feb 25, 2024
@rewin123 rewin123 added this to the 0.4 milestone Feb 25, 2024
@rewin123 rewin123 merged commit dd3ccc3 into main Feb 25, 2024
7 checks passed
@naomijub naomijub deleted the fix-multiple-selection branch March 5, 2024 02:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants