-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow to edit subscene entities #235
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #235 +/- ##
==========================================
+ Coverage 31.63% 31.85% +0.21%
==========================================
Files 57 58 +1
Lines 8408 8677 +269
==========================================
+ Hits 2660 2764 +104
- Misses 5748 5913 +165 ☔ View full report in Codecov by Sentry. |
It works well on my side and doesnt seem to have any code issue. I would just add a few tests, specially for the new module |
Solves #183 |
Flaky test failed |
Allow to edit entites, which cannot be stored natively (for example gltf scene entities)