Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow to edit subscene entities #235

Merged
merged 12 commits into from
Mar 4, 2024
Merged

Allow to edit subscene entities #235

merged 12 commits into from
Mar 4, 2024

Conversation

rewin123
Copy link
Owner

@rewin123 rewin123 commented Mar 3, 2024

Allow to edit entites, which cannot be stored natively (for example gltf scene entities)

@rewin123 rewin123 requested a review from naomijub March 3, 2024 10:04
@rewin123 rewin123 added this to the 0.4 milestone Mar 3, 2024
@rewin123 rewin123 added prefab Request/issue about prefab logic editor ui labels Mar 3, 2024
Copy link

codecov bot commented Mar 3, 2024

Codecov Report

Attention: Patch coverage is 42.85714% with 184 lines in your changes are missing coverage. Please review.

Project coverage is 31.85%. Comparing base (4abeddb) to head (2ff2358).

❗ Current head 2ff2358 differs from pull request most recent head b29c4ca. Consider uploading reports for the commit b29c4ca to get more accurate results

Files Patch % Lines
crates/prefab/src/sub_scene/mod.rs 33.03% 148 Missing ⚠️
crates/editor_ui/src/hierarchy.rs 0.00% 18 Missing ⚠️
crates/prefab/src/spawn_system.rs 5.88% 16 Missing ⚠️
crates/prefab/src/plugins.rs 0.00% 1 Missing ⚠️
crates/prefab/src/save.rs 97.36% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #235      +/-   ##
==========================================
+ Coverage   31.63%   31.85%   +0.21%     
==========================================
  Files          57       58       +1     
  Lines        8408     8677     +269     
==========================================
+ Hits         2660     2764     +104     
- Misses       5748     5913     +165     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@naomijub
Copy link
Collaborator

naomijub commented Mar 3, 2024

It works well on my side and doesnt seem to have any code issue. I would just add a few tests, specially for the new module

@naomijub
Copy link
Collaborator

naomijub commented Mar 4, 2024

Solves #183

@naomijub
Copy link
Collaborator

naomijub commented Mar 4, 2024

Flaky test failed

@naomijub naomijub merged commit 8c38033 into main Mar 4, 2024
5 of 6 checks passed
@naomijub naomijub deleted the edit-subscene branch March 5, 2024 02:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
editor ui prefab Request/issue about prefab logic
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants