-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Type agnostic tab name and easy startup layout modification for editor_tabs #272
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## v0.6 #272 +/- ##
==========================================
- Coverage 34.78% 34.57% -0.21%
==========================================
Files 62 67 +5
Lines 9301 9418 +117
==========================================
+ Hits 3235 3256 +21
- Misses 6066 6162 +96 ☔ View full report in Codecov by Sentry. |
Might be a linker problem on CI. Maybe we could run CI on windows or be sure to have it correctly setup for linux https://github.com/bevyengine/bevy/blob/main/docs/linux_dependencies.md But I see this is passing now |
I would always recommend adding UI screenshots when changing stuff that touch the UI, besides that, this is a pretty good change and clearly documented. |
Sometimes space_editor folder fills 20-30 gb of my disk space for debug target. So, I switched to release mode to try to fix this |
UI shouldn't have changed, just the api |
} | ||
|
||
pub enum DoublePanel { | ||
TopPanel, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe call them TopLeftPanel and BottomLeftPanel? first time I read them I felt confused with the menutoolbars
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe then call TopLeft and BottomLeft? I love reducing words count
Part of #267
This PR allows you to:
Major changes:
Usage:
Next steps in next PRs: