Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 63 - Add components window #69

Merged
merged 6 commits into from
Nov 23, 2023
Merged

Issue 63 - Add components window #69

merged 6 commits into from
Nov 23, 2023

Conversation

naomijub
Copy link
Collaborator

On inspector right click, if there is an entity selected, an Add Components window will pop up:

image

There is an issue:

  • if you leave the window in the gameview area, if moves the game camera.

@naomijub
Copy link
Collaborator Author

@rewin123 I think it feels great with this change, please feedback

@naomijub
Copy link
Collaborator Author

Tried to fix the camera movement when Add components is on top of game view the camera moves as well :(
Any ideas?

@rewin123
Copy link
Owner

Try

world.resource_mut::<crate::editor::PanOrbitEnabled>().0 = false;

before 'update_pan_orbit' system

@rewin123
Copy link
Owner

rewin123 commented Nov 23, 2023

I hope you don't oppose outside changes to the pull request, I've added a camera control fix and added an additional button to call the context window for adding a component. Now it is possible to call both by right mouse button and by clicking on "Add component" button. If all ok, i will merge.

@naomijub
Copy link
Collaborator Author

Awesome, no problem with collab PRs

@rewin123 rewin123 marked this pull request as ready for review November 23, 2023 14:19
@rewin123 rewin123 merged commit ded7991 into rewin123:main Nov 23, 2023
4 checks passed
@naomijub naomijub deleted the issue-65/new-tabs branch November 24, 2023 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants