Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue 62/file reorg #85

Merged
merged 8 commits into from
Dec 1, 2023
Merged

Issue 62/file reorg #85

merged 8 commits into from
Dec 1, 2023

Conversation

naomijub
Copy link
Collaborator

@naomijub naomijub commented Nov 30, 2023

Attempt to solve #62

This branch extracts prefab and editor registry crates to a workspace containing crates folder. As a consequence, some other crates were created, like undo and shared.
Another significant change has been move all optional crates to a Modules folder in the workspace. Currently the only crate located in modules is bevy_xpbd_plugin.

@rewin123
Copy link
Owner

Fixed failure. The problem was that I split bevy_xpbd into two plugins "prefab" and "editor". Both should connect when loading editor, and only one when loading only prefab crate. In case of editor loading before the fix, only "editor" part of bevy_xpbd was loaded without prefab logic

@naomijub naomijub marked this pull request as ready for review December 1, 2023 00:32
@naomijub
Copy link
Collaborator Author

naomijub commented Dec 1, 2023

I'm tempted to try [email protected] to fix this lints 😬

@rewin123 rewin123 merged commit 2143022 into rewin123:main Dec 1, 2023
4 checks passed
@naomijub naomijub deleted the issue-62/file-reorg branch December 1, 2023 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants