🤖 Added extensions support #101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
awtkns
reviewed
Dec 18, 2024
Comment on lines
2
to
4
| import shutil | ||
| import tempfile | ||
|
|
There was a problem hiding this comment.
remove, i dont think you are using these
awtkns
reviewed
Dec 18, 2024
| @@ -39,6 +42,7 @@ async def playwright_harness( | |||
| browser_type: Optional[BrowserType] = None, | |||
| enable_clipboard: bool = False, | |||
| launch_args: Sequence[str] = (), | |||
| extensions: Sequence[str] = (), | |||
There was a problem hiding this comment.
Make sure to add this to the HarnessOptions type
awtkns
approved these changes
Dec 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add browser extension support to
playwright_harness()for Chromium and update version to 0.57.0.extensionsparameter toplaywright_harness()inharness.pyto support loading browser extensions for Chromium.shutilandtempfileinharness.pyfor temporary directory management.0.57.0incore/pyproject.tomlandsdk/pyproject.toml.This description was created by
for 0bc2416. It will automatically update as commits are pushed.