Add post request handling and BeautifulSoup integration #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![ellipsis-dev[bot]](https://avatars.githubusercontent.com/in/64358?s=60&v=4){kind=small}
awtkns
reviewed
Jan 6, 2025
awtkns
reviewed
Jan 7, 2025
awtkns
reviewed
Jan 7, 2025
sdk/harambe/contrib/soup/impl.py
Outdated
Comment on lines
108
to
114
| content_type = res.headers.get("Content-Type", "") | ||
| if "application/json" in content_type: | ||
| return res.json() | ||
| self._soup = BeautifulSoup(res.text, "html.parser") | ||
|
|
||
| class SoupResponseWithStatus: | ||
| status: int = res.status_code |
There was a problem hiding this comment.
We we should include res.json() in SoupResponseWithStatus as body
awtkns
reviewed
Jan 7, 2025
…d JSON data serialization
awtkns
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Important
Add
post()method inSoupPagefor POST requests and integrate BeautifulSoup for response parsing.post()method inSoupPageinimpl.pyto handle POST requests with headers and payloads.0.59.2inpyproject.tomlanduv.lockfor bothharambe-coreandharambe-sdk.beautifulsoup4as a dependency insdk/pyproject.toml.This description was created by
for 5fdcc59. It will automatically update as commits are pushed.