Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add dynamic waiting mechanism for new page openings in capture_url method #108

Merged
merged 8 commits into from
Jan 22, 2025

Conversation

mohamedmamdouh22
Copy link
Collaborator

@mohamedmamdouh22 mohamedmamdouh22 commented Jan 14, 2025

Implements a feature to dynamically wait for a new page to open when triggered by an capture_url Includes a timeout mechanism to prevent indefinite waiting and ensure robustness.


Important

Add dynamic waiting with timeout to capture_url method in core.py and update version to 0.59.5.

  • Behavior:
    • capture_url method in core.py now includes a timeout parameter to dynamically wait for new page openings.
    • Implements _wait_for_new_page in handlers.py to handle dynamic waiting with a timeout.
  • Versioning:
    • Update version to 0.59.5 in pyproject.toml and uv.lock for both harambe-core and harambe-sdk.

This description was created by Ellipsis for e0b698f. It will automatically update as commits are pushed.

@awtkns awtkns merged commit c007d42 into main Jan 22, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants