Phone number validation #28
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
awtkns
reviewed
May 31, 2024
|
|
||
| phone_number_formats = [ | ||
| r"^\d{3,11}$", # 911 & 11111111111 | ||
| r"^(\(?\+\d{1,2}\)?\s)?\(?\d{3}\)?[\s.-]?\d{3}[\s.-]?\d{4}$", # +1 (628) 555-3456 & (+1) 415-155-1555 |
There was a problem hiding this comment.
some phone numbers have multiple international prefxies, does the below work?
| Phone Number Dialed | Location |
|---|---|
| 456-7890 | Local Phone Number |
| 212-456-7890 | Domestic |
| +1-212-456-7890 | International Phone Number |
| 1-212-456-7890 | Dialed in the US |
| 001-212-456-7890 | Dialed in Germany |
| 191-212-456-7890 | Dialed in France |
There was a problem hiding this comment.
Good question, I'll check now, thank you for more examples!
There was a problem hiding this comment.
Negatronic, only "212-456-7890" worked ; expanding the regex and making a PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very basic implementation using regular expressions (currently it's literally one regular expression).
Please let me know if this approach seems like the right way to go, and feel free to provide as many different examples as possible — that'll help me construct more regular expressions and write more tests for the validator.