Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Catch 2.11.0 fails to build tests #177

Closed
Psypher9 opened this issue Oct 26, 2022 · 1 comment
Closed

Catch 2.11.0 fails to build tests #177

Psypher9 opened this issue Oct 26, 2022 · 1 comment

Comments

@Psypher9
Copy link
Collaborator

When running make for the full solution, the Catch 2 dependency fails to build resulting in the following errors

.../tests/catch.hpp:10717:58: error: call to non-‘constexpr’ function ‘long int sysconf(int)’
10717 |     static constexpr std::size_t sigStackSize = 32768 >= MINSIGSTKSZ ? 32768 : MINSIGSTKSZ;

and

/tests/catch.hpp:10776:45: error: size of array ‘altStackMem’ is not an integral constant-expression
10776 |     char FatalConditionHandler::altStackMem[sigStackSize] = {};

These errors are directly addressed in an April 2021 release of Catch 2, found here. The original issue is here.

Expected Behavior:

  • I can run a full build with make
    • The tests build
    • The tests run and pass
  • Catch 2 is updated to the latest non-breaking version
Psypher9 added a commit to Psypher9/riftshadow that referenced this issue Oct 26, 2022
@sean-gilliam
Copy link
Collaborator

Merged by #178

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants