fix(sale): generate_sales_subscription_offers now returns true

rezoleo · Aug 3, 2024 · 720c7d2 · 720c7d2
1 parent 8894741
commit 720c7d2
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/app/controllers/sales_controller.rb b/app/controllers/sales_controller.rb
@@ -14,8 +14,9 @@ def new
 
   def create
     @sale = @owner.sales_as_client.new(sales_params)
-    return redirect_to :new_user_sale, user: @user, status: :unprocessable_entity unless
-      @sale.generate(duration: params[:sale][:duration], seller: current_user)
+    unless @sale.generate(duration: params[:sale][:duration], seller: current_user)
+      return redirect_to :new_user_sale, user: @user, status: :unprocessable_entity
+    end
     return redirect_to :new_user_sale, user: @user, status: :unprocessable_entity if @sale.empty?
 
     authorize! :create, @sale

diff --git a/app/models/sale.rb b/app/models/sale.rb
@@ -72,7 +72,7 @@ def generate_sales_subscription_offers(duration)
         duration -= quantity * offer.duration
       end
     end
-    return if duration.zero?
+    return true if duration.zero?
 
     errors.add(:base, 'Subscription offers are not exhaustive!')
     false