Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pokemon! #789

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

pokemon! #789

wants to merge 9 commits into from

Conversation

frankiethull
Copy link
Contributor

Thank you for your submission! Please leave this text as-is when you submit, and then check the checklist.

Usability:

  • This dataset has not already been used in TidyTuesday.
  • The dataset is less than 20MB when saved as a tidy CSV.
  • [x ] I can imagine at least one data visualization related to this dataset.

Preparation:

  • cleaning.R has code to download and clean the dataset, resulting in descriptively-named data.frames.
  • I ran saving.R to create csvs and md data dictionaries for each of my data.frames.
  • I filled in descriptions for each variable in each of the {dataset}.md files.
  • I edited the intro.md file to introduce my dataset.
  • I included at least one image for my dataset as a png file.
  • I completed the information in meta.yaml, including descriptive alt text for each image.
  • I provided information in meta.yaml about how to credit me, and deleted any parts of that block that I do not want you to use.

Copy link
Collaborator

@jonthegeek jonthegeek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few tweaks needed overall, but the main thing is that your submission directory is ephemeral; we only keep the pieces designated in the instructions. If you want to use an article that you wrote for the article link, you need to publish it on your own GitHub account. It's also fine to link to virtually anything about Pokemon for the article.

Thanks for the submission!

title: Pokemon
article:
title: Gotta Catch Em All?
url: github.com/frankiethull/tidytuesday/tree/pokemon/data/curated/pokemon/article.md
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link needs to be to an existing thing on the internet. This directory is deleted during the acceptance process, so it can't "live" here. Either publish it on your own GitHub, or provide a link to anything about Pokemon, ideally showing some use of data, but something like the source of the data or a wikipedia article about Pokemon or anything else would work.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was originally thinking the article would live on my fork. But I'll go with the second idea, providing a link to anything about Pokemon. Will look around for one that uses the underlying data (if possible).

# Please include at least one image, and up to three images
- file: pokemon.png
alt: >
Image shows faceted scatterplots of pokemon dataset. x = attack; y = defense; facet = pokemon type; color = primary pokemon color;
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Describe the image in a way that serves to replace the image when the image isn't available. What does the plot show? Are there trends? Is there one type that stands out as more defense-focused, or another that's more attack-focused? Or maybe pointing out the type with the strongest attack and the type with the strongest defense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants