-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cleanup of airctrl.py #81
Conversation
Thank you for the PR. I will try to review and provide feedback soon. |
Sorry for taking me so long to get to this. I have reviewed and tested your changes, everything looks fine to me!
vs.
|
No problem, was busy too. Well yes I think the proposed change at the end of the main function would be the best position if we want to add the get after a set. Maybe in another PR. |
tl;dr
I did a bigger refactoring last year and added the coap-part, but changes in airctrl.py where only a first approach.
There where differences in output and many redundances between the 3 protocols (http, plaincoap and coap)
This PR cleans airctrl.py - output will be the same no matter which protocol you use
longer information, points to pay attention
changes to cli:
added CliBase to have a common formatting class depending on STATUS_TRANSFORMER
updated STATUS_TRANSFORMER class:
attention - changed formatting:
attention - changed behaviour:
tests were adjusted and build green