Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate GetBerryCountString #4010

Closed
pkmnsnfrn opened this issue Jan 16, 2024 · 1 comment
Closed

Deprecate GetBerryCountString #4010

pkmnsnfrn opened this issue Jan 16, 2024 · 1 comment
Labels
feature-request Requests a new feature

Comments

@pkmnsnfrn
Copy link
Collaborator

Description

Originally mentioned here: #4001 (comment)

We should deprecate GetBerryCountString in favor of CopyItemNameHandlePlural (or something similar).

Discord contact info

pkmnsnfrn

@pkmnsnfrn pkmnsnfrn added the feature-request Requests a new feature label Jan 16, 2024
pkmnsnfrn added a commit to PokemonSanFran/pokeemerald-expansion that referenced this issue Jan 16, 2024
Will deprecate the former in a future feature: rh-hideout#4010
Bassoonian added a commit that referenced this issue Jan 16, 2024
…tems are received at once (#4001)

* Updated CopyItemNameHandlePlural to deal with plural names

* Fixed whitespace in a few places

* Fixed whitespace in a few places

* Add remaining plural forms.

* Created ITEM_NAME_PLURAL_LENGTH

* Updated ITEM_NAME_PLURAL_LENGTH per feedback https://github.com/rh-hideout/pokeemerald-expansion/pull/4001\#discussion_r1453598165

* Reverted ITEM_NAME_PLURAL_LENGTH to +2 and added new comment

* Removed GetBerryCountString from CopyItemNameHandlePlural
Will deprecate the former in a future feature: #4010

---------

Co-authored-by: Zimmermann Gyula <[email protected]>
Co-authored-by: Bassoonian <[email protected]>
@AlexOn1ine
Copy link
Collaborator

#4012

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request Requests a new feature
Projects
None yet
Development

No branches or pull requests

2 participants