Shadows for all 'mons interact badly with trainerslide messages

[hedara90]

Description

Discovered by Mystic Gohan on discord.
Tested and verified by hedara.

abyss.mp4

The shadow of the active 'mon will move over to the trainer sprite during a trainerslide, usually in the wrong place for the trainer.

Version

upcoming (Edge)

Upcoming/master Version

No response

Discord contact info

hedara

[AsparagusEduardo]

Do we want to keep the milestone for this issue? #5632 already added a warning for this, and I can imagine that it's a small enough issue that it's non-blocking for 1.10's release.

[kittenchilly]

Didn't we disable shadows by default because of this though?

[AsparagusEduardo]

That's why I'm asking if it's a good enough of a patch to free a release. I'm still working on the script to migrate the chages from 1.9 to 1.10 in gSpeciesInfo and the current PRs, so this doesn't need to be decided now.

[Pawkkie]

I would absolutely agree that it's not 1.10 blocking, we wanted to have 1.10 out more than a week ago and I don't think delaying it for anything that isn't explicitly gamebreaking at this point is worthwhile.

[Pawkkie]

Removing from 1.10 milestone after senate vote