Trainerslide animation fix #6040
Conversation
| @@ -290,7 +290,6 @@ | |||
| #define B_SHOW_TYPES SHOW_TYPES_NEVER // When defined as SHOW_TYPES_ALWAYS, after selecting "Fight" in battle, the types of all Pokemon are revealed. Whe defined as SHOW_TYPES_OWN, types are only revealed if the player owns the mon in question. | |||
|
|
|||
| // Pokémon battle sprite settings | |||
| #define B_ENEMY_MON_SHADOW_STYLE GEN_3 // In Gen4+, all enemy Pokemon will have a shadow drawn beneath them. | |||
| // Currently Gen4+ shadows don't properly work with Trainerslides | |||
| #define B_ENEMY_MON_SHADOW_STYLE GEN_LATEST // In Gen4+, all enemy Pokemon will have a shadow drawn beneath them. | |||
There was a problem hiding this comment.
This may be worth mentioning in the changelog (using the PRing template to make sure the changelog generator parses it properly)
There was a problem hiding this comment.
Isn't it already mentioned in the PR description and the auto-parsing part of it?
There was a problem hiding this comment.
Oops, I glanced over that, yeah. Regardless, I do think "re-enabling" doesn't automatically imply the default state of a config has changed - at least for me, it'd imply something deeper in the codebase was changed instead.
There was a problem hiding this comment.
Reworded and expanded upon
|
Just to check: has this also been confirmed to work in double battles? |
Double battles work for both slots, multi-battles work for both slots. |
Description
Decoupled trainer slide sprites from battlers.
Enemy battler shadows set to
GEN_LATESTsince that setting no longer interferes with trainerslides.Images
slide.mp4
Issue(s) that this PR fixes
Fixes #5565
Things to note in the release changelog:
B_ENEMY_MON_SHADOW_STYLEset toGEN_LATESTsince that setting no longer interferes with trainerslides. Set it toGEN_3to use regular Gen 3 shadow style.Discord contact info
hedara