-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Decapitalization of berries 'names #2050
Decapitalization of berries 'names #2050
Conversation
Isn't that specifically overworld related? I think it's out of scope for any of the 3 branches, if so. |
I thought it was OK, since everything else berry related is decapped. But if the other maintainers feel this way, by all means close this PR. Edit: I just found out that those names also control the name on the Berry tag, so it's not related to just the overworld. |
Yeah, I don't see how this is out of scope, but you'll need to decap all the names to keep consistency |
Do you mean the old Berries' names? I didn't decap those because I thought the policy was to keep the vanilla stuff intact (just like in the BE where new battle message are uncapped and the old aren not). |
I'm (slowly) working on a PR that addresses this with Ultima's blessing, so those will be decapped and updated to modern gens soon. Asparagus's point on consistency stands either way. |
Decapped the old Berries' names (and the descriptions). Let me know if I missed something and sorry for the delay. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You're missing some BERRY
s for the descriptions.
Also, you're missing the e-reader Enigma Berry.
Sorry about that. Should be all good to go now. |
Description
Quick PR that fixes the names in src/berry.c (the ones that appear by interacting with berry plants).
Discord contact info
SubzeroEclipse#7867