Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decapitalization of berries 'names #2050

Merged
merged 3 commits into from Feb 19, 2022
Merged

Decapitalization of berries 'names #2050

merged 3 commits into from Feb 19, 2022

Conversation

ghost
Copy link

@ghost ghost commented Feb 8, 2022

Description

Quick PR that fixes the names in src/berry.c (the ones that appear by interacting with berry plants).

Discord contact info

SubzeroEclipse#7867

@LOuroboros
Copy link
Collaborator

the ones that appear by interacting with berry plants

Isn't that specifically overworld related? I think it's out of scope for any of the 3 branches, if so.

@ghost
Copy link
Author

ghost commented Feb 9, 2022

the ones that appear by interacting with berry plants

Isn't that specifically overworld related? I think it's out of scope for any of the 3 branches, if so.

I thought it was OK, since everything else berry related is decapped. But if the other maintainers feel this way, by all means close this PR.

Edit: I just found out that those names also control the name on the Berry tag, so it's not related to just the overworld.

@AsparagusEduardo
Copy link
Collaborator

the ones that appear by interacting with berry plants

Isn't that specifically overworld related? I think it's out of scope for any of the 3 branches, if so.

I thought it was OK, since everything else berry related is decapped. But if the other maintainers feel this way, by all means close this PR.

Edit: I just found out that those names also control the name on the Berry tag, so it's not related to just the overworld.

Yeah, I don't see how this is out of scope, but you'll need to decap all the names to keep consistency

@ghost
Copy link
Author

ghost commented Feb 14, 2022

Yeah, I don't see how this is out of scope, but you'll need to decap all the names to keep consistency

Do you mean the old Berries' names? I didn't decap those because I thought the policy was to keep the vanilla stuff intact (just like in the BE where new battle message are uncapped and the old aren not).

@MandL27
Copy link

MandL27 commented Feb 14, 2022

just like in the BE where new battle message are uncapped and the old aren not

I'm (slowly) working on a PR that addresses this with Ultima's blessing, so those will be decapped and updated to modern gens soon. Asparagus's point on consistency stands either way.

@ghost
Copy link
Author

ghost commented Feb 14, 2022

Decapped the old Berries' names (and the descriptions). Let me know if I missed something and sorry for the delay.

Copy link
Collaborator

@AsparagusEduardo AsparagusEduardo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're missing some BERRYs for the descriptions.

Also, you're missing the e-reader Enigma Berry.

@ghost
Copy link
Author

ghost commented Feb 18, 2022

You're missing some BERRYs for the descriptions.

Also, you're missing the e-reader Enigma Berry.

Sorry about that. Should be all good to go now.

@AsparagusEduardo AsparagusEduardo merged commit 7e7060b into rh-hideout:item_expansion Feb 19, 2022
@ghost ghost deleted the IE_decaps branch March 4, 2022 17:43
hedara90 pushed a commit to hedara90/pokeemerald-expansion that referenced this pull request Nov 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants