PartyBattlerShouldAvoidHazards rewrite

[Sneed69]

In its current state, PartyBattlerShouldAvoidHazards is flawed and incomplete.

• It checks for Levitate against Stealth Rock
• It sets a nonsensical value to holdEffect so Heavy Duty Boots are not checked for
• It ignores type effectiveness for SR
• It ignores the amount of laid spikes and some spike immunities.
• It does not account for spikes and SR overlapping.

I fixed the above issues and added more checks that make sense.
A function was added to check for SR damage against a non battler, instead passing a max HP and two type arguments.

[ghoulslash]

This is a good PR, but looking at ShouldPivot as a whole, I'm concerned about the call to ShouldSwitch potentially invoking BtlController_EmitTwoReturnValues mid-AI calc, overwriting potentially useful bufferA or bufferB data.

I suppose its somewhat unrelated to this PR, but if you are invested in switching logic it may be good to try and fix here as well

[Sneed69]

I actually have no idea what emitting even is, sorry.
Most of battle_controllers.c is gibberish to me.
Having said that, I didn't find any references to BUFFER_A in ShouldSwitch which sounds good?

[DarkCrobat]

This is a good change that I need to implement in the switching logic checks, since we want to dissuade the AI from switching if entry hazards are present and they will be effective against us.

It looks like ShouldPivot is mostly deprecated, in lue of the ShouldSwitch function, which other battle_ai functions are calling instead. The only place that ShouldPivot is still used is in Move - Parting Shot.

The switching logic has been fleshed out to handle logic for switching for abilities that benefit from it (Regenerator, Natural Cure) I will do the same with moves that benefit from switching. (Such as Parting Shot)